Re: [PATCH v18 4/8] mfd: p3h2x4x: Add driver for NXP P3H2x4x i3c hub and on-die regulator

From: Lee Jones

Date: Tue Sep 15 2026 - 07:19:32 EST


On Fri, 11 Sep 2026, Lakshay Piplani wrote:

>
> NXP Public
> > -----Original Message-----
> > From: Lakshay Piplani <lakshay.piplani@xxxxxxx>
> > Sent: Thursday, September 3, 2026 11:51 AM
> > To: linux-kernel@xxxxxxxxxxxxxxx; linux-i3c@xxxxxxxxxxxxxxxxxxx;
> > alexandre.belloni@xxxxxxxxxxx; krzk+dt@xxxxxxxxxx; robh@xxxxxxxxxx;
> > conor+dt@xxxxxxxxxx; devicetree@xxxxxxxxxxxxxxx; broonie@xxxxxxxxxx;
> > lee@xxxxxxxxxx; Frank Li <frank.li@xxxxxxx>; lgirdwood@xxxxxxxxx
> > Cc: Vikash Bansal <vikash.bansal@xxxxxxx>; Priyanka Jain
> > <priyanka.jain@xxxxxxx>; Aman Kumar Pandey
> > <aman.kumarpandey@xxxxxxx>; Lakshay Piplani <lakshay.piplani@xxxxxxx>
> > Subject: [PATCH v18 4/8] mfd: p3h2x4x: Add driver for NXP P3H2x4x i3c hub
> > and on-die regulator
> >
> > From: Aman Kumar Pandey <aman.kumarpandey@xxxxxxx>
> >
> > Add core MFD support for the NXP P3H2x4x
> > (P3H2440/P3H2441/P3H2840/P3H2841) family of multiport I3C hub devices.
> > These devices connect to a host via I3C/I2C/SMBus and expose multiple
> > downstream target ports.
> >
> > All variants share the same register interface. The driver reads the target-port
> > count from DEV_CAPAB and applies the DT configuration, so no per-compatible
> > driver data is required.
> >
> > Signed-off-by: Aman Kumar Pandey <aman.kumarpandey@xxxxxxx>
> > Signed-off-by: Vikash Bansal <vikash.bansal@xxxxxxx>
> > Signed-off-by: Lakshay Piplani <lakshay.piplani@xxxxxxx>
> > Reviewed-by: Frank Li <Frank.Li@xxxxxxx>
>
> Hi Lee,
>
> A gentle follow-up on this MFD patch. Could you please review it when you have a chance?

Don't do that!

It was on the list, but since I handle all of my reviews in
reverse-chronological order, you just put yourself at the back of it.

--
Lee Jones