Re: [PATCH net-next v18 3/3] net: phy: Add driver for Motorcomm Quad 2.5GbE phy

[Andrew Lunn]

> +	res = of_get_phy_mode(np, &priv->interface_mode);
> +	if (res < 0) {
> +		phydev_warn(phydev, "%s, phy-mode missing in DTS.\n", __func__);
> +		priv->interface_mode = PHY_INTERFACE_MODE_INTERNAL;

In the binding you say phy-mode is a required property. So if it is
missing, it should be a fatal error.

	 Andrew