Re: [PATCH v2 3/6] ASoC: qcom: lpass-macro-common: Add LPASS codec version 4.1

[Mohammad Rafi Shaik]

On 9/13/2026 2:16 PM, Krzysztof Kozlowski wrote:
> On Thu, Sep 10, 2026 at 03:16:54PM +0530, Mohammad Rafi Shaik wrote:
> > Shikra integrates LPASS codec version 4.1. Add the new version to the
> > codec version enum and to the version string helper.
> >
> > The enum stays ordered by version so that the existing '>=' comparisons
> > on enum lpass_codec_version keep working.
> >
> > Signed-off-by: Mohammad Rafi Shaik <mohammad.rafi.shaik@xxxxxxxxxxxxxxxx>
> > ---
> >   sound/soc/codecs/lpass-macro-common.h | 3 +++
> >   1 file changed, 3 insertions(+)
> >
> > diff --git a/sound/soc/codecs/lpass-macro-common.h b/sound/soc/codecs/lpass-macro-common.h
> > index 573b2145e..b52665b11 100644
> > --- a/sound/soc/codecs/lpass-macro-common.h
> > +++ b/sound/soc/codecs/lpass-macro-common.h
> > @@ -30,6 +30,7 @@ enum lpass_codec_version {
> >   	LPASS_CODEC_VERSION_2_7,
> >   	LPASS_CODEC_VERSION_2_8,
> >   	LPASS_CODEC_VERSION_2_9,
> > +	LPASS_CODEC_VERSION_4_1,
> >   };
> >   
>
> This commit no sense on its own. You added dead code here. Add this with
> an user of that version..
Ack,

will fold this change into the patch that actually starts using the 4.1 
version support instead of introducing it separately.

Best Regards,
Rafi.

> Best regards,
> Krzysztof