Re: [PATCH] media: i2c: ar0521: remove duplicate media entity cleanup
From: Krzysztof Hałasa
Date: Tue Sep 15 2026 - 09:23:18 EST
Hi Guangshuo,
Guangshuo Li <lgs201920130244@xxxxxxxxx> writes:
> There is no need to clean up the media entity twice.
Definitely.
Thanks for fixing this.
Acked-by: Krzysztof Hałasa <khalasa@xxxxxxx>
> Fixes: 852b50aeed15 ("media: On Semi AR0521 sensor driver")
> Signed-off-by: Guangshuo Li <lgs201920130244@xxxxxxxxx>
> --- a/drivers/media/i2c/ar0521.c
> +++ b/drivers/media/i2c/ar0521.c
> @@ -1142,7 +1142,6 @@ static int ar0521_probe(struct i2c_client *client)
>
> disable:
> v4l2_async_unregister_subdev(&sensor->sd);
> - media_entity_cleanup(&sensor->sd.entity);
> free_ctrls:
> v4l2_ctrl_handler_free(&sensor->ctrls.handler);
> entity_cleanup:
--
Krzysztof "Chris" Hałasa
Sieć Badawcza Łukasiewicz
Przemysłowy Instytut Automatyki i Pomiarów PIAP
Al. Jerozolimskie 202, 02-486 Warszawa