Re: [PATCH v2 5/6] ASoC: qcom: lpass-va-macro: Add shikra compatible

[Mohammad Rafi Shaik]

On 9/14/2026 5:17 PM, Srinivas Kandagatla wrote:
> On 9/10/26 10:46 AM, Mohammad Rafi Shaik wrote:
> > Add shikra specific VA macro data and register programming needed by
> > the LPASS codec v4.0 implementation.
> > +static const struct regmap_config va_4_1_regmap_config = {
> > +	.name = "va_macro",
> > +	.reg_bits = 32,
> > +	.val_bits = 32,
> > +	.reg_stride = 4,
> > +	.cache_type = REGCACHE_FLAT,
>
> Pl use MAPLE here.

Thanks for the suggestion. I will switch to REGCACHE_MAPLE and update it 
in the next revision.

> >   		regmap_update_bits(regmap, CDC_VA_CLK_RST_CTRL_FS_CNT_CONTROL,
> >   				   CDC_VA_FS_CONTROL_EN | CDC_VA_FS_COUNTER_CLR,
> >   				   CDC_VA_FS_CONTROL_EN | CDC_VA_FS_COUNTER_CLR);
> > +
> > +		if (lpass_macro_get_codec_version() >= LPASS_CODEC_VERSION_4_1)
> same comment as in 4/5 patch use a flag.

Ack, Will introduce a flag or switch-case mechanism to handle this 
configuration.

Best Regards,
Rafi.