Re: [PATCH v16 03/11] media: qcom: camss: Add Kaanapali compatible

[Loic Poulain]

On Tue, Sep 15, 2026 at 12:10 PM Hangxiang Ma
<hangxiang.ma@xxxxxxxxxxxxxxxx> wrote:
>
> Add CAMSS_KAANAPALI enum, Kaanapali compatible and Kaanapali CAMSS driver
> private data, the private data just include some basic information
> now, later changes will enumerate with CSIPHY, TPG, CSID and VFE
> resources.
>
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@xxxxxxxxxx>
> Signed-off-by: Hangxiang Ma <hangxiang.ma@xxxxxxxxxxxxxxxx>

Reviewed-by: Loic Poulain <loic.poulain@xxxxxxxxxxxxxxxx>


> ---
>  drivers/media/platform/qcom/camss/camss.c | 22 ++++++++++++++++++++++
>  drivers/media/platform/qcom/camss/camss.h |  1 +
>  2 files changed, 23 insertions(+)
>
> diff --git a/drivers/media/platform/qcom/camss/camss.c b/drivers/media/platform/qcom/camss/camss.c
> index 07b3cddca584..2c9f02bca809 100644
> --- a/drivers/media/platform/qcom/camss/camss.c
> +++ b/drivers/media/platform/qcom/camss/camss.c
> @@ -34,6 +34,20 @@
>
>  static const struct parent_dev_ops vfe_parent_dev_ops;
>
> +static const struct resources_icc icc_res_kaanapali[] = {
> +       {
> +               .name = "ahb",
> +               .icc_bw_tbl.avg = 150000,
> +               .icc_bw_tbl.peak = 300000,
> +       },
> +       /* Based on 4096 x 3072 30 FPS 2496 Mbps mode */
> +       {
> +               .name = "hf_mnoc",
> +               .icc_bw_tbl.avg = 471860,
> +               .icc_bw_tbl.peak = 925857,
> +       }
> +};
> +
>  static const struct camss_subdev_resources csiphy_res_8x16[] = {
>         /* CSIPHY0 */
>         {
> @@ -5596,6 +5610,13 @@ static void camss_remove(struct platform_device *pdev)
>         camss_genpd_cleanup(camss);
>  }
>
> +static const struct camss_resources kaanapali_resources = {
> +       .version = CAMSS_KAANAPALI,
> +       .pd_name = "top",
> +       .icc_res = icc_res_kaanapali,
> +       .icc_path_num = ARRAY_SIZE(icc_res_kaanapali),
> +};
> +
>  static const struct camss_resources msm8916_resources = {
>         .version = CAMSS_8x16,
>         .csiphy_res = csiphy_res_8x16,
> @@ -5829,6 +5850,7 @@ static const struct camss_resources x1e80100_resources = {
>  };
>
>  static const struct of_device_id camss_dt_match[] = {
> +       { .compatible = "qcom,kaanapali-camss", .data = &kaanapali_resources },
>         { .compatible = "qcom,msm8916-camss", .data = &msm8916_resources },
>         { .compatible = "qcom,msm8939-camss", .data = &msm8939_resources },
>         { .compatible = "qcom,msm8953-camss", .data = &msm8953_resources },
> diff --git a/drivers/media/platform/qcom/camss/camss.h b/drivers/media/platform/qcom/camss/camss.h
> index ba3d51d9c0bf..fadba57c5efa 100644
> --- a/drivers/media/platform/qcom/camss/camss.h
> +++ b/drivers/media/platform/qcom/camss/camss.h
> @@ -96,6 +96,7 @@ enum camss_version {
>         CAMSS_8550,
>         CAMSS_8650,
>         CAMSS_8775P,
> +       CAMSS_KAANAPALI,
>         CAMSS_X1E80100,
>  };
>
>
> --
> 2.34.1
>