Re: [PATCH] Revert "interconnect: qcom: x1e80100: enable QoS configuration"

[Abel Vesa]

On 26-09-15 13:37:03, Marc Zyngier wrote:
> This reverts commit 5a8b2cc36e796d595c9d97eab23c2be22805cc1c.
> 
> Since the introduction of this QoS change, X1 machines based on the
> Purwa SoC (such as the Lenovo Mini X) take a hard reset at boot time.
> 
> Other machines based on Hamoa (such as the X1E001DE Snapdragon Devkit)
> end-up with a similar hard reset while under load, most likely due to
> the PCIe ports being starved of traffic.
> 
> Revert the whole thing until someone figures out what magic parameters
> allow QoS to work in a sensible manner, as a usable machine is somehow
> preferable to one that crashes efficiently.
> 
> Link: https://lore.kernel.org/all/apgeBNSiP01YfNcs@xxxxxxxxxx
> Link: https://lore.kernel.org/all/86ld9d4h4n.wl-maz@xxxxxxxxxx
> Signed-off-by: Marc Zyngier <maz@xxxxxxxxxx>
> Cc: Georgi Djakov <djakov@xxxxxxxxxx>
> Cc: Raviteja Laggyshetty <raviteja.laggyshetty@xxxxxxxxxxxxxxxx>
> Cc: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
> Cc: Abel Vesa <abelvesa@xxxxxxxxxx>
> Cc: Bjorn Andersson <andersson@xxxxxxxxxx>
> Cc: Mostafa Saleh <smostafa@xxxxxxxxxx>
> Cc: Thorsten Leemhuis <regressions@xxxxxxxxxxxxx>

Sent mine here:

https://lore.kernel.org/all/20260915-icc-qcom-x1e80100-revert-qos-enabling-v1-1-cc4ba943bd9d@xxxxxxxxxxxxxxxx/

But yours looks good, so:

Reviewed-by: Abel Vesa <abel.vesa@xxxxxxxxxxxxxxxx>