Re: [PATCH v4 08/10] regulator: ab8500: Add buck converter support

[Mark Brown]

On Mon, Sep 14, 2026 at 11:11:21PM +0200, Linus Walleij wrote:
> Register the SMPS1, SMPS2, SMPS3, ARM, APE and MOD buck converters on
> AB8500 and the VSMPSA, VSMPSB, VSAFE, VARM, VSMPSC and VSMPSM buck
> converters on AB8505 so that the new device tree nodes can supply
> consumers. Match each variant through its own device tree node names.

> +static const struct regulator_ops ab8500_buck_ops = {
> +	.enable			= ab8500_regulator_enable,
> +	.disable		= ab8500_regulator_disable,
> +	.is_enabled		= ab8500_regulator_is_enabled,
> +	.get_optimum_mode	= ab8500_regulator_get_optimum_mode,
> +	.set_mode		= ab8500_regulator_set_mode,
> +	.get_mode		= ab8500_regulator_get_mode,

Without of_map_mode() at least the set part of this will be unusuable.
Not a blocker though.

Attachment: signature.asc
Description: PGP signature