Re: [PATCH] clocksource/drivers/digicolor: Fix clk reference leak on request_irq failure

[Baruch Siach]

Hi Wentao Liang,

On Tue, Sep 15 2026, Wentao Liang wrote:
> digicolor_timer_init() obtains the timer clock with of_clk_get() and
> enables it, but the request_irq() failure path returns without releasing
> the clock reference, leaking both the enable/prepare state and the
> reference itself.
>
> Disable and put the clock before returning on the request_irq() failure
> path. The success path keeps the clock enabled for the lifetime of the
> timer and is left untouched.
>
> Fixes: 9b8bb7736b78 ("clocksource: Driver for Conexant Digicolor SoC timer")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Wentao Liang <vulab@xxxxxxxxxxx>

Acked-by: Baruch Siach <baruch@xxxxxxxxxx>

Thanks,
baruch

> ---
>  drivers/clocksource/timer-digicolor.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/clocksource/timer-digicolor.c b/drivers/clocksource/timer-digicolor.c
> index 559aa96089c3..46e0c329957a 100644
> --- a/drivers/clocksource/timer-digicolor.c
> +++ b/drivers/clocksource/timer-digicolor.c
> @@ -190,6 +190,8 @@ static int __init digicolor_timer_init(struct device_node *node)
>  			  &dc_timer_dev.ce);
>  	if (ret) {
>  		pr_warn("request of timer irq %d failed (%d)\n", irq, ret);
> +		clk_disable_unprepare(clk);
> +		clk_put(clk);
>  		return ret;
>  	}

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@xxxxxxxxxx - tel: +972.52.368.4656, http://www.tkos.co.il -