Re: [PATCH v4] ASoC: tas2783-sdw: add firmware download status check

[Mark Brown]

On Tue, Sep 15, 2026 at 11:52:23AM +0800, Baojun Xu wrote:
> Currently, the firmware download is unnecessarily triggered on every
> system resume from suspend, causing significant wake-up latency. However,
> this step is redundant if the AMP remains powered on.

> -	tas_dev->fw_dl_success = false;
> +	regmap_read(tas_dev->regmap, TASDEV_REG_SDW(0, 0, 7), &val);
> +	/* Check if the AMP is in reset status. */
> +	if (val == 0x20) {
> +		tas_dev->fw_dl_success = false;

Don't we also need to set the flag to true if we're skipping download,
what'll happen if we get here if the firmware was downloaded prior to
the driver starting (eg, you can probably trigger that with a bind/unbind)?

Attachment: signature.asc
Description: PGP signature