Re: [PATCH bpf-next v2 2/2] bpf, parisc: Add support for BPF_SDIV and BPF_SMOD in the parisc32 JIT
From: Nicholas Dudar
Date: Tue Sep 15 2026 - 16:06:26 EST
On Tue, Sep 15, 2026, bot+bpf-ci@xxxxxxxxxx wrote:
> This looks like a bug fix for the parisc32 JIT's handling of signed
> division and modulo operations. Should this include a Fixes: tag?
>
> Fixes: 847b98421362 ("adding ci files")
847b98421362 only adds CI files, not parisc JIT changes.
I submitted this as missing instruction support to bpf-next without Fixes,
following the RV32/i386 guidance [1,2], as explained on parisc v1 [3].
The current unsigned results for signed operations are still incorrect.
> This isn't a bug, but would it be worth naming the sibling commit (or
> saying "the previous patch") instead of "patch 1" here, so the reference
> still makes sense once the series is applied?
Agreed. Please replace "helpers added in patch 1 (64-bit)" with
"signed 64-bit helpers" when applying. The preceding text already names
hppa_sdiv64() and hppa_sdiv64_rem().
BPF maintainers: please consider both patches for stable after mainline
inclusion, patch 2 needs patch 1's helpers. Per the BPF guide, I'm requesting
this here rather than adding a Cc: stable trailer.
Thank you,
Nicholas
[1] https://lore.kernel.org/bpf/fa8a040f-64c4-484f-9538-fb0ec287639f@xxxxxxxxxx/
[2] https://lore.kernel.org/bpf/alWEj2hDtxz8RW-l@xxxxxxxxxx/
[3] https://lore.kernel.org/bpf/CAJZwKkgG2Ct3KipN4cRgg4v=QQwj9LhA8pveqQvT_gQ_GpzJ3w@xxxxxxxxxxxxxx/