Re: [PATCH] vfs: clean up indenting in lookup_open()
From: Jan Kara
Date: Tue Sep 15 2026 - 16:41:12 EST
On Tue 15-09-26 19:37:53, Dan Carpenter wrote:
> These lines are indented too far. Delete a tab.
>
> Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>
Looks good. Feel free to add:
Reviewed-by: Jan Kara <jack@xxxxxxx>
Honza
> ---
> fs/namei.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/namei.c b/fs/namei.c
> index 1dd4ec7d0e62..48b28ed44a9e 100644
> --- a/fs/namei.c
> +++ b/fs/namei.c
> @@ -4636,9 +4636,9 @@ static struct dentry *lookup_open(struct nameidata *nd, struct file *file,
> if (create_dir) {
> struct dentry *res = vfs_mkdir_no_perm(idmap, dir_inode, dentry,
> mode, &delegated_inode);
> - error = PTR_ERR_OR_ZERO(res);
> - if (!error)
> - dentry = res;
> + error = PTR_ERR_OR_ZERO(res);
> + if (!error)
> + dentry = res;
> } else {
> error = vfs_create_no_perm(idmap, dentry, mode, &delegated_inode);
> }
> --
> 2.53.0
>
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR