Re: [v2 for-next 2/3] block: allow error injection rules to delay bios

[Haris Iqbal]

On 9/15/26 23:24, Haris Iqbal wrote:
> On 9/15/26 11:11, Christoph Hellwig wrote:
> > The delay does look fine, but I'd really like to not use up one of the
> > scare bio flags for it.  Can we insist on the delay only working for
> > an error, so that we never have to reinsert?
>
> We can do that, but that's only half of the feature, and the weaker half 
> IMHO. Only delay with a successful completion covers a more useful 
> scenario for testing in the upper layers.
>
> I am thinking about how else we can do this, but did not find a nice 
> approach.
>
> Maybe we can #ifdef the new flag on CONFIG_BLK_ERROR_INJECTION?

I forgot one small point in favour of the flag.

We can remove addition of __submit_bio_noacct_nocheck() function, since 
with the flag the re-entry after the delay would fail on 
blk_error_inject(). This would remove confine the change to 
error_injection files.