Re: [PATCH] perf/x86/intel: Replace snprintf with strscpy in intel_pmu_init

[Ian Rogers]

On Sat, Jan 31, 2026 at 4:21 AM Thorsten Blum <thorsten.blum@xxxxxxxxx> wrote:
>
> Replace snprintf("%s", ...) with the faster and more direct strscpy().
>
> Signed-off-by: Thorsten Blum <thorsten.blum@xxxxxxxxx>

Reviewed-by: Ian Rogers <irogers@xxxxxxxxxx>

Thanks,
Ian

> ---
>  arch/x86/events/intel/core.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/x86/events/intel/core.c b/arch/x86/events/intel/core.c
> index bdf3f0d0fe21..025971ab6341 100644
> --- a/arch/x86/events/intel/core.c
> +++ b/arch/x86/events/intel/core.c
> @@ -12,6 +12,7 @@
>  #include <linux/types.h>
>  #include <linux/init.h>
>  #include <linux/slab.h>
> +#include <linux/string.h>
>  #include <linux/export.h>
>  #include <linux/nmi.h>
>  #include <linux/kvm_host.h>
> @@ -8077,7 +8078,7 @@ __init int intel_pmu_init(void)
>                 }
>         }
>
> -       snprintf(pmu_name_str, sizeof(pmu_name_str), "%s", name);
> +       strscpy(pmu_name_str, name);
>
>         if (!is_hybrid()) {
>                 group_events_td.attrs  = td_attr;
> --
> Thorsten Blum <thorsten.blum@xxxxxxxxx>
> GPG: 1D60 735E 8AEF 3BE4 73B6  9D84 7336 78FD 8DFE EAD4
>