Re: [PATCH v3 8/8] ASoC: codecs: add Qualcomm Tambora (WCD9378) SDCA codec

[Srinivas Kandagatla]

On 9/15/26 6:22 PM, Uwe Kleine-König wrote:
> Hello,
> 
> On Tue, Sep 15, 2026 at 05:56:50PM +0100, Srinivas Kandagatla wrote:
>> +#include <linux/mod_devicetable.h>
>> +#include <linux/module.h>
>> +#include <linux/pm.h>
>> +#include <linux/pm_runtime.h>
>> +#include <linux/soundwire/sdw.h>
>> +#include <linux/soundwire/sdw_type.h>
> 
> You can and should rely on sdw_device_id being provided by
> <linux/soundwire/sdw.h>. So please drop <linux/mod_devicetable.h> which
> makes a bunch of useless build dependencies go away with it.
> 

thanks for the comments both fixed in new version.

--srini
>> +#include "wcd9378-sdca.h"
>> +
>> +static const struct dev_pm_ops wcd9378_sdw_pm_ops = {
>> +	SYSTEM_SLEEP_PM_OPS(wcd9378_sdca_system_suspend,
>> +			    wcd9378_sdca_system_resume)
>> +	RUNTIME_PM_OPS(wcd9378_sdca_runtime_suspend,
>> +		       wcd9378_sdca_runtime_resume, NULL)
>> +};
>> +
>> +static const struct sdw_slave_ops wcd9378_sdw_ops = {
>> +	.read_prop = wcd9378_sdca_read_prop,
>> +};
>> +
>> +static const struct sdw_device_id wcd9378_sdw_id[] = {
>> +	SDW_SLAVE_ENTRY(0x0217, 0x0110, 0),
>> +	{}
>> +};
> 
> s/{}/{ }/ please
> 
> Best regards
> Uwe