Re: [PATCH v4 0/4] tdx-guest: Make Quote buffer size dynamic
From: Edgecombe, Rick P
Date: Tue Sep 15 2026 - 20:12:14 EST
On Tue, 2026-09-15 at 16:04 -0700, Peter Fang wrote:
> Just to be extra clear... Patch 4 added this:
>
> if (quote_size)
> /* The reported size does not include the buffer header */
> len = TDX_QUOTE_BUF_LEN(quote_size);
>
> And it is about adding the GHCI header to the buffer size. So if there
> is a design change and this header is no longer needed, this line could
> become redundant. The macro might cause the driver to allocate more
> memory than needed (up to one page), so things should still work and we
> could fix this up later.
So this series uses a new ability to query the max size of the quote. This size
applies to SGX quotes too.
Depending on the DICE design, the guest quoting code may need to change. Maybe
heavily. These changes could touch LOC in this series as well as other TDX guest
quoting code. But the code is still correct and useful based on non-DICE
existing quoting.
Is it all correct?