Re: [PATCH 2/3] EDAC/i3000: Balance PCI device enablement

[Borislav Petkov]

On Tue, Sep 15, 2026 at 06:15:56PM -0700, Borislav Petkov wrote:
> Tony,
> 
> I have recently started marking obsolete EDAC drivers as orphaned because,
> well, they don't deserve the effort.
> 
> How about this one?
> 
> On Mon, Sep 14, 2026 at 09:55:18PM -0400, Myeonghun Pak wrote:
> > i3000_init_one() leaves the PCI enable reference held when probing fails
> > and when the controller is removed. Disable the device on probe failure
> > and after removing the EDAC controller. Keep explicit cleanup because
> > module initialization can call i3000_init_one() outside PCI driver binding.
> > 
> > This issue was identified during our ongoing static-analysis research
> > while reviewing kernel code.
> > 
> > Fixes: 535c6a53035d ("drivers/edac: new inte 30x0 MC driver")
> > Cc: stable@xxxxxxxxxxxxxxx
> > Assisted-by: LLM
> > Co-developed-by: Ijae Kim <ae878000@xxxxxxxxx>
> > Signed-off-by: Ijae Kim <ae878000@xxxxxxxxx>
> > Signed-off-by: Myeonghun Pak <mhun512@xxxxxxxxx>
> > ---
> >  drivers/edac/i3000_edac.c | 4 ++++
> >  1 file changed, 4 insertions(+)

Oh, that one is an orphan already:

./scripts/get_maintainer.pl -f drivers/edac/i3000_edac.c
EDAC-I3000 status: Orphan

You can save your energy doing fixes for it.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette