Re: [PATCH net v3 1/2] net: phy: qca808x: accept the active-high LED polarity mode

[Christian Marangi]

On Wed, Sep 16, 2026 at 07:31:37AM +0900, Donggeun Yoo wrote:
> commit a274465cc3be ("net: phy: support 'active-high' property for PHY LEDs")
> added PHY_LED_ACTIVE_HIGH, but qca808x_led_polarity_set() still rejects
> everything except PHY_LED_ACTIVE_LOW. An LED node carrying 'active-high'
> therefore falls into the default case and returns -EINVAL, which
> phy_probe() propagates: the mdio device is left unbound and
> phy_attach_direct() falls back to the genphy driver, so the PHY loses
> every qca808x-specific feature, not just the LED.
> 
> Accept the mode. The register write below already handles both
> polarities.
> 
> Cc: stable@xxxxxxxxxxxxxxx
> Fixes: a274465cc3be ("net: phy: support 'active-high' property for PHY LEDs")
> Signed-off-by: Donggeun Yoo <donggeunyoo.kernel@xxxxxxxxx>
> Assisted-by: Claude:claude-fable-5

Reviewed-by: Christian Marangi <ansuelsmth@xxxxxxxxx>

-- 
	Ansuel