Re: [PATCH net 3/8] net: bcmgenet: do not skip WoL power up on GENET V1

[netdev-bot+sashiko]

Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.

Low priority / nit picks for your consideration:

- [Low] The submitted commit "net: bcmgenet: do not skip WoL power up on
  GENET V1" (d8dc741c84b2) carries no Signed-off-by: line.

--

net: bcmgenet: do not skip WoL power up on GENET V1

The patch moves the bcmgenet_has_ext() test out of the top of
bcmgenet_power_up() and into the GENET_POWER_PASSIVE and
GENET_POWER_CABLE_SENSE cases, so that GENET_POWER_WOL_MAGIC reaches
bcmgenet_wol_power_up_cfg() on GENET V1 where the EXT block is absent.

The only comment below is about the commit message trailers, so the diff
hunks are not quoted.

>     Fixes: 1c1008c793fa ("net: bcmgenet: add main driver file")
>     Assisted-by: LLM
>     Co-authored-by: Cursor <cursoragent@xxxxxxxxxx>
>     Change-Id: Id6c85b2790191786aa535d71fea357d1cd49a2ec

[Severity: Low]
This isn't a code bug, but the trailer block of this commit has no
Signed-off-by: line. Without it the Developer's Certificate of Origin is
not asserted, so can this be applied by a netdev maintainer as posted?

The block also ends with:

    Change-Id: Id6c85b2790191786aa535d71fea357d1cd49a2ec

Change-Id is a Gerrit-local artifact. Should it be stripped before posting
so it does not end up in kernel history?

Since the change carries a Fixes: tag and is therefore a stable backport
candidate, the authorship and sign-off trailers matter for the tooling that
picks it up. The same trailer pattern appears on the other commits of this
series, so would it make sense to fix them all together in a v2?

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260918000732.276506-1-florian.fainelli%40broadcom.com