Re: [PATCH v13 05/15] cxl: Introduce reusable HDM decoder settings

[Jonathan Cameron]

> > @@ -48,7 +48,7 @@ static void cxld_set_type(struct cxl_decoder *cxld, u32 *ctrl)
> >   * clock skew and other marginal behavior
> >   */
> >  #define COMMIT_TIMEOUT_MS 20
> > -int cxld_await_commit(void __iomem *hdm, int id)
> > +static int cxld_await_commit(void __iomem *hdm, int id)
> >  {
> >  	u32 ctrl;
> >  	int i;
> > @@ -68,43 +68,40 @@ int cxld_await_commit(void __iomem *hdm, int id)
> >  	return -ETIMEDOUT;
> >  }


> > +int cxl_commit_wait(void __iomem *hdm, struct cxl_decoder_settings *settings)  
> 
> No reason to rename this. Either just use cxld_await_commit() directly, or just
> change the signature of cxld_await_commit().
> 
> > +{
> > +	return cxld_await_commit(hdm, settings->config.id);
> >  }

Please crop replies!  Saves time if hopefully a number of people
are looking at them + ensures that the stuff that actually needs discussing
doesn't get missed.

Comment looks good though once I found it!

Thanks,

Jonathan