Re: [PATCH net 1/3] net: macb: never give hardware a NULL RX buffer

From: Jakub Kicinski

Date: Thu Sep 24 2026 - 11:54:35 EST


On Thu, 24 Sep 2026 17:13:58 +0200 Théo Lebrun wrote:
> > If the AI interprets the rx poll side correctly these seem like a major
> > flaw in setting the USED bit :(
>
> Yes the AI is correct (unsurprisingly). But two things:

If it's correct then patch needs to be changed.
Please don't write puzzles for me to solve.

> - before this patch what happened was that HW read the NULL descriptor,
> so not much better
> - we can detect in gem_rx() using our ring buffer cursors that tell us
> what we've managed to allocate, that we gem_rx() doesn't iterate
> over descriptors that haven't been allocated

Grammatically dubious puzzles at that.