Re: [PATCH net 1/3] net: fealnx: fix teardown order in remove
From: Francois Romieu
Date: Thu Sep 24 2026 - 17:55:02 EST
Жамбакиев Радий Рикардинович <r.zhambakiev@xxxxxxxxxxxxxxxxx> :
> From: Radiy Zhambakiev <r.zhambakiev@xxxxxxxxxxxxxxxxx>
>
> fealnx_remove_one() frees the DMA rings before unregistering the
> netdev, while the interface may still be up, which leaves a
> window where freed memory can be accessed.
>
> Call unregister_netdev() first so dev_close() stops the Tx/Rx
> engines, deletes the timers, and frees the IRQ before the rings are
> freed.
Fine. A single line of code needs to be moved.
> While at it use dev_err() instead of printk() for the unknown-device case.
Unrelated stuff.
--
Ueimor