Re: [PATCH v4 2/2] spi: qcom-geni: Use GPIO to notify master of SPI target activity

[Mark Brown]

On Mon, Aug 24, 2026 at 07:56:00PM +0530, Praveen Talari wrote:

> When operating in SPI target mode, the GENI controller relies on an
> external GPIO to notify the SPI master about the target's active state.

> +	if (spi->target) {
>  		spi->target_abort = spi_geni_target_abort;
> +		mas->ready_gpio = devm_gpiod_get_optional(dev, "ready",
> +							  GPIOD_OUT_LOW);
> +		if (IS_ERR(mas->ready_gpio)) {
> +			dev_err(dev, "Failed to request GPIO: %ld\n",
> +				PTR_ERR(mas->ready_gpio));
> +			mas->ready_gpio = NULL;

I'll apply this since it probably doesn't actually matter but this is
broken for probe deferral, and might cause issues if the system really
does have a GPIO but it fails for some reason.  It's better to just
handle all errors as errors, _optional() already returns NULL if the
GPIO is genuintely missing.

Attachment: signature.asc
Description: PGP signature