Re: [PATCH] ext4: fix race between inline dir conversion and folio read

[Sandeep Dhavale]

>
> Good catch! At least the first paragraph below would be also useful in the
> commit changelog - the realworld impact is important information. But I
> guess Ted can modify the changelog on commit if he wants. Feel free to add:
>
> Reviewed-by: Jan Kara <jack@xxxxxxx>
>
>                                                                 Honza
>
Hi Jan,
Thanks for the review!

Hi Ted,
Is that something you can add while applying or shall I send v2 with
just updated commit message?

Thanks,
Sandeep.
> > ---
> > Note:
> > This issue was reported by an Android partner encountering kernel panics
> > in ext4_dirblock_csum_verify() ("No space for directory leaf checksum")
> > on 16KB page size kernels mounting a 4KB block size ext4 filesystem.
> >
> > We verified with a standalone reproducer that the race reproduces
> > deterministically on Iteration 0 (< 1s) on both ARM64 (16KB page size,
> > 4KB ext4 blocks) and upstream ext4-tree/dev on x86_64 (4KB page size,
> > 1KB ext4 blocks), and confirmed that this patch resolves the issue.
> >
> >  fs/ext4/inline.c | 1 +
> >  fs/ext4/namei.c  | 2 ++
> >  2 files changed, 3 insertions(+)