Re: [PATCH 0/3] Move memory acceptance x86 arch code into EFI stub
From: Edgecombe, Rick P
Date: Thu Sep 24 2026 - 19:30:23 EST
On Thu, 2026-09-24 at 12:46 +0100, Kiryl Shutsemau wrote:
> > Is there any way we could make some progress here?
> >
> > Ultimately, the thing I am after is to get rid of the call from the
> > decompressor to EFI stub's snprintf(), which I want to remove. For
> > the time being, I am more than happy leaving the memory acceptance where
> > it is, and just dropping the call to snprintf().
>
> Please go ahead with the move. Rick's questions are about what
> tdx_accept_memory() should return, not about where the caller lives,
> and can be sorted out separately.
Yep. I tried to do a quick smoke test and got a similar build error as Boris. I
guess you will send a new revision?
ld: warning: orphan section `.altinstructions' from
`drivers/firmware/efi/libstub/x86-stub.stub.o' being placed in section
`.altinstructions'
ld: warning: orphan section `.altinstr_replacement' from
`drivers/firmware/efi/libstub/x86-stub.stub.o' being placed in section
`.altinstr_replacement'
ld: Unexpected GOT/PLT entries detected!
ld: Unexpected run-time procedure linkages detected!
ld: Unexpected run-time relocations (.rela) detected!
ld: arch/x86/boot/compressed/tdx-shared.o: in function `tdx_panic.cold':
tdx-shared.c:(.text.unlikely+0xc): undefined reference to `__fortify_panic'
ld: tdx-shared.c:(.text.unlikely+0x1e): undefined reference to `__fortify_panic'
ld: drivers/firmware/efi/libstub/x86-stub.stub.o: in function
`arch_accept_memory':
x86-stub.c:(.text+0x17f5): undefined reference to `pv_ops'
ld: drivers/firmware/efi/libstub/x86-stub.stub.o:(.altinstr_replacement+0x1):
undefined reference to `BUG_func'
ld: arch/x86/boot/compressed/vmlinux: hidden symbol `__SCK__WARN_trap' isn't
defined
ld: final link failed: bad value