Re: [PATCH 6/8] drm/amd/display: remove redundant cast on amdgpu_dc_reg_template printk

[Tvrtko Ursulin]

On 24/09/2026 22:10, Melissa Wen wrote:
> Commit 0cf5eb76e2b4 ("drm/amd/display: Add tracing to dc") prints and
> casts uint32_t fields in amdgpu_dc_reg_template to unsigned long
> unnecessarily. Just print those fields with %08x and remove the
> redundant cast.
>
> Assisted-by: Claude:claude-opus-5-5
> Signed-off-by: Melissa Wen <mwen@xxxxxxxxxx>
> ---
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_trace.h | 5 ++---
>   1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_trace.h b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_trace.h
> index 26c85d95bcc0..7de4fe355c5d 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_trace.h
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_trace.h
> @@ -57,9 +57,8 @@ DECLARE_EVENT_CLASS(amdgpu_dc_reg_template,
>   				   *count = *count + 1;
>   		    ),
>   
> -		    TP_printk("reg=0x%08lx, value=0x%08lx",
> -			      (unsigned long)__entry->reg,
> -			      (unsigned long)__entry->value)
> +		    TP_printk("reg=0x%08x, value=0x%08x",
> +			      __entry->reg, __entry->value)
>   );
>   
>   DEFINE_EVENT(amdgpu_dc_reg_template, amdgpu_dc_rreg,

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxxx>

Regards,

Tvrtko