Re: [RFC PATCH net-next v2] net: pcs: airoha: add support for Airoha AN7583 SoC

[Andrew Lunn]

> +static void an7583_pcs_setup_scu_pcie(struct airoha_pcs_priv *priv,
> +				      int index, phy_interface_t interface)
> +{
> +	u32 xsi_sel;
> +
> +	if (priv->phy)
> +		return;
> +
> +	switch (interface) {
> +	case PHY_INTERFACE_MODE_USXGMII:
> +	case PHY_INTERFACE_MODE_10GBASER:
> +	default:
> +		xsi_sel = AIROHA_SCU_PCIE_XSI1_USXGMII;
> +	}
> +
> +	regmap_update_bits(priv->scu, AIROHA_SCU_SSTR,
> +			   AIROHA_SCU_PCIE_XSI1_SEL,
> +			   xsi_sel);

I suspect the AI will be here soon. xsi_sel is initially a random
stack value. IF interface is something else, you use that random value
with regmap_update_bits().

>  static const struct of_device_id airoha_pcs_of_table[] = {
>  	{ .compatible = "airoha,an7581-pcs-eth", .data = &an7581_pcs_eth },
>  	{ .compatible = "airoha,an7581-pcs-pon", .data = &an7581_pcs_pon },
>  	{ .compatible = "airoha,an7581-pcs-pcie", .data = &an7581_pcs_pcie },
>  	{ .compatible = "airoha,an7581-pcs-usb", .data = &an7581_pcs_usb },
> +	{ .compatible = "airoha,an7583-pcs-eth", .data = &an7583_pcs_eth },
> +	{ .compatible = "airoha,an7583-pcs-pon", .data = &an7583_pcs_pon },
> +	{ .compatible = "airoha,an7583-pcs-pcie", .data = &an7583_pcs_pcie },
> +	{ .compatible = "airoha,an7583-pcs-usb", .data = &an7583_pcs_usb },

Device tree binding update to list these new compatibles?

	Andrew