Re: [PATCH v2] scsi: qedf: drop invalid skb_transport_header check to prevent panic

[Jesse Taube]

On Thu, May 28, 2026 at 2:36 AM Nimal Prabudoss I <nprabudo@xxxxxxxxxx> wrote:
>
> During intensive FCOE Tier 1 CTC boot tests, the qedf driver triggers a
> warning assertion in include/linux/skbuff.h. This happens because the
> driver attempts to access an uninitialized transport header offset via
> skb_transport_header() under a CONFIG_DEBUG_NET environment.
>
> Remove the invalid helper call within qedf_recv_frame() to eliminate the
> warning assertion and prevent the subsequent system panic.
>
> Co-developed-by: Jesse T <jtaubepe@xxxxxxxxxx>
> Signed-off-by: Nimal Prabudoss I <nprabudo@xxxxxxxxxx>
> Signed-off-by: Jesse T <jtaubepe@xxxxxxxxxx>

BUMP.
The order of signoffs acording to checkpatch should be
Co-developed-by: Jesse T <jtaubepe@xxxxxxxxxx>
Signed-off-by: Jesse T <jtaubepe@xxxxxxxxxx>
Signed-off-by: Nimal Prabudoss I <nprabudo@xxxxxxxxxx>


Thanks,
Jesse Taube

> ---
>  drivers/scsi/qedf/qedf_main.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c
> index da429b3a4283..f2bc0ac684e0 100644
> --- a/drivers/scsi/qedf/qedf_main.c
> +++ b/drivers/scsi/qedf/qedf_main.c
> @@ -2496,7 +2496,6 @@ static void qedf_recv_frame(struct qedf_ctx *qedf,
>
>         /* Pull the header */
>         hp = (struct fcoe_hdr *)skb->data;
> -       fh = (struct fc_frame_header *) skb_transport_header(skb);
>         skb_pull(skb, sizeof(struct fcoe_hdr));
>         fr_len = skb->len - sizeof(struct fcoe_crc_eof);
>
> --
> 2.54.0
>