Re: [PATCH 6/6] ASoC: codecs: aw88166: make volume control usable
From: Aaron Kling
Date: Fri Sep 25 2026 - 12:27:36 EST
On Fri, Sep 25, 2026 at 11:18 AM Mark Brown <broonie@xxxxxxxxxx> wrote:
>
> On Fri, Sep 25, 2026 at 11:05:42AM -0500, Aaron Kling wrote:
> > On Fri, Sep 25, 2026 at 9:18 AM Mark Brown <broonie@xxxxxxxxxx> wrote:
> > > On Fri, Sep 25, 2026 at 02:47:34AM -0500, Aaron Kling via B4 Relay wrote:
>
> > > > - Invert the value to match userspace expectations (in the hardware,
> > > > positive numbers represent negative dB attenuation)
>
> > > That's a very bad compatibility break, if anyone has a profile saved
> > > they might get excessively loud volume from their existing configuration
> > > which could be distressing. It might be better to rename the control.
>
> > Mmm. At the risk of sounding like a broken record, is this any
> > different from the accepted aw88261 change? I wouldn't be specifically
> > opposed to a new control as my use case, Android, is very tightly
> > controlled and I can just update the audio config I ship. But more
> > standard Linux use cases that rely on a standardize control name would
> > be stuck with a non-standard inverted control forever.
>
> Why would renaming the control do that?
I might be misunderstanding something, but I thought there were
standardized names, like this "PCM Playback Volume" that tools and os
handling expect and will use if found. Which would cause a second
control with a different name to not get used. Is there something I'm
missing to where a new control would get used without manual
intervention?
Aaron