Re: [PATCH net-next v8 1/3] net/sched: sch_fq_pie: add per-flow statistics via class ops

[Jakub Kicinski]

On Thu, 24 Sep 2026 21:00:39 +0000 netdev-bot+sashiko@xxxxxxxxxx wrote:
> [Severity: Low]
> Should Documentation/netlink/specs/tc.yaml be updated along with this?
> 
> In the spec, tc-fq-pie-xstats still lists only the nine original u32
> members. The tca-stats-app-msg sub-message still binds fq_pie to it:
> 
>       -
>         value: fq_pie
>         fixed-header: tc-fq-pie-xstats
> 
> The spec has no type member, no class-stats member, no tc-fq-pie-cl-stats
> struct and no enum for TCA_FQ_PIE_XSTATS_QDISC/CLASS.
> 
> A spec-driven (YNL) decoder will only decode the first 36 bytes of the new
> 64-byte payload. It cannot tell class records from qdisc records, and it
> never shows prob, delay, deficit, avg_dq_rate or dq_rate_estimating.
> 
> tc.yaml is still unchanged at the end of the series (after "net/sched: pie:
> correct tc_pie_xstats field documentation").

Looks legit, please check the other Low severity review comments.