Re: [PATCH net-next] net: mctp: Stop selecting flow support for KUnit tests
From: Karl Mehltretter
Date: Sat Sep 26 2026 - 04:43:49 EST
On Sat, Sep 26, 2026 at 03:53:28PM +0100, Jeremy Kerr wrote:
> Hi Karl,
>
> > MCTP_TEST selects MCTP_FLOWS, which also enables SKB_EXTENSIONS when no
> > transport requires them.
>
> But we want to test the flows support, why disable this (and
> consequently skip the flow tests in the vast majority of test runs)?
>
> > Remove the selection to follow the dependency
> > rule in Documentation/dev-tools/kunit/style.rst.
>
> That suggests "depending on", rather than removing the coverage.
>
Hi Jeremy,
Thanks for the review!
OK, I can change that.
I was confused by the existing !MCTP_FLOWS fallbacks, but now understand
that you want the suite to retain full flow-test coverage.
Karl