Re: [PATCH net-next v12 01/15] phylink: Add phylink_mac_interrupt

[Birger Koblitz]

On 17/09/2026 11:24 pm, netdev-bot+sashiko@xxxxxxxxxx wrote:
> Thank you for your contribution! Sashiko AI review found 2 potential
> issue(s) to consider:
>
> Critical: 0 · High: 0 · Medium: 1 · Low: 1
>
> - [Medium] `phylink_mac_interrupt()`
>    (drivers/net/phy/phylink.c:1621-1628) reads `pl->phydev` with no…

This does not look like an actual problem, as the interrupt is not 
really an IRQ, it is a call from the MAC layer, calling 
phy_mac_interrupt(phy) did the same in the past.

> - [Low] Claim that the newly exported `phylink_mac_interrupt()`
>    (drivers/net/phy/phylink.c) and its prototype…
See above.

> --
>
> phylink: Add phylink_mac_interrupt
>
> This adds an exported phylink_mac_interrupt() helper which forwards a
> link-change interrupt received by the MAC to phylib by calling
> phy_mac_interrupt() on pl->phydev.  It is intended for drivers that want to
> avoid polling the PHY.
>
> (no Link: tags in the commit header)