Re: [PATCH net-next v12 04/15] ax88179_178a: Split driver into library and device specific code

[Birger Koblitz]

On 17/09/2026 11:24 pm, netdev-bot+sashiko@xxxxxxxxxx wrote:
> Thank you for your contribution! Sashiko AI review found 2 potential
> issue(s) to consider:
>
> Critical: 0 · High: 0 (1) · Medium: 1 (5) · Low: 1
>
> - [Medium] The module is renamed from ax88179_178a.ko to ax88179.ko
>    (drivers/net/usb/Makefile: `obj-$(CONFIG_USB_NET_AX88179_178A) +=…
> - [Low] New-file hygiene problems in the added files.
Added module-alias MODULE_ALIAS("ax88179_178a") as suggested

> Pre-existing issues:
> - [High] ax88179_get_eeprom() (drivers/net/usb/ax88179_lib.c) can copy
>    uninitialized kernel heap bytes to userspace when the attached USB…
> - [Medium] ax88179_set_features() (drivers/net/usb/ax88179_lib.c:338-364)
>    ignores every command result.
> - [Medium] ax88179_change_mtu() (drivers/net/usb/ax88179_lib.c:400-426)
>    commits the software MTU first (`WRITE_ONCE(net->mtu, new_mtu);…
> - [Medium] ax88179_set_mac_addr() (drivers/net/usb/ax88179_lib.c:425-443)
>    calls eth_hw_addr_set(net, addr->sa_data) before issuing the…
> - [Medium] ax88179_mdio_read() (drivers/net/usb/ax88179_lib.c:151-158)
>    discards the return value of ax88179_read_cmd() and returns the output…
> - [Medium] ax88179_set_eeprom() (drivers/net/usb/ax88179_lib.c:229-297)
>    mixes byte-oriented userspace data with native-word register helpers,…
Will fix where touched, see later commits.