Re: [PATCH net-next v12 07/15] ax88179_178a: Add EEE configuration support for AX88179A MACs

[Birger Koblitz]

On 17/09/2026 11:24 pm, netdev-bot+sashiko@xxxxxxxxxx wrote:
> Thank you for your contribution! Sashiko AI review found 4 potential
> issue(s) to consider:
>
> Critical: 0 · High: 0 · Medium: 1 · Low: 3
>
> - [Medium] The AX179A EEE control register (AX_GPHY_CTL /
>    AX_GPHY_EEE_CTRL) is never forced to a known state, while the driver…
Added setting of AX_GPHY_EEE_CTRL to disabled in ax88179a_reset(),
consistent with phylink default.

> - [Low] In this patch alone, ax88179a_phylink_mac_ops gains
>    .mac_enable_tx_lpi/.mac_disable_tx_lpi while ax88179a_phylink_setup()…
Not relevant as further functionality added in later parts of the series.

> - [Low] The changelog of "ax88179_178a: Add EEE configuration support for
>    AX88179A MACs" ends with the truncated/incorrect sentence "Add support…
Commit message fixed.

> - [Low] At this commit, ax88179a_ethtool_ops
>    (drivers/net/usb/ax88179a_devices.c:209) has no .get_eee/.set_eee…

Not relevant since the further functions are added in later parts of the
series.