Re: [PATCH net-next v12 10/15] ax88179_178a: Add AX179A/AX279 multicast configuration

[Birger Koblitz]

On 17/09/2026 11:25 pm, netdev-bot+sashiko@xxxxxxxxxx wrote:
> Thank you for your contribution! Sashiko AI review found 2 potential
> issue(s) to consider:
>
> Critical: 0 · High: 1 · Medium: 1 · Low: 0
>
> - [High] ax88179_set_multicast() (drivers/net/usb/ax88179_lib.c:305) now
>    only sets AX_RX_CTL_IPE when data->ip_align is non-zero (line 314).
Fixed by moving setting ax179_data->ip_align = 1 in ax88179_bind() 
already in a previous patch where ip_align is first introduced.

> - [Medium] Registering ax88179_set_multicast() as .ndo_set_rx_mode for
>    the AX88179A family (drivers/net/usb/ax88179a_devices.c:618) creates a…

Will not fix. I extensively tested this and could not trigger the race.
Switching multicast/promiscous modes is a rare operation in reality,
so the likelyhood of hitting this is extremely small, and in any case this
will heal itself on link changes or if the user repeats the operation.
The existing driver had the same pattern for > 10 years without issues.