Re: [PATCH net-next v12 14/15] ax88179_178a: Add support for AX88179A/772D/279 EEPROM access

[Birger Koblitz]

On 17/09/2026 11:25 pm, netdev-bot+sashiko@xxxxxxxxxx wrote:
> Thank you for your contribution! Sashiko AI review found 3 potential
> issue(s) to consider:
>
> Critical: 0 · High: 0 · Medium: 3 · Low: 0
>
> - [Medium] The patch smuggles an undisclosed RX-path repair into an
>    "EEPROM access" commit: `ax88179_bind()` now sets…
ip_align moved to patch adding HW support.

> - [Medium] `ax88179_eeprom_access_params()`
>    (drivers/net/usb/ax88179_lib.c:197-214) picks the hardware address…
Will change the gating in ax88179_eeprom_access_params to correspond to
the eeprom_read_cmd/eeprom_block gating in bind(), i.e. use
else if (ax179_data->chip_version == AX_VERSION_AX88279) .
get_eeprom() changed to reject reads from chip_version > 
AX_VERSION_AX88279 to prevent the use of the AX88279 access 
configuration with future unknown devices.
As for hypothetical legacy devices with chip_version > 
AX_VERSION_AX88279, they do not exist according to the vendor information.

> - [Medium] `ax88179_get_eeprom()` (drivers/net/usb/ax88179_lib.c:237-249)
>    only rejects `ret < 0` from `__ax88179_read_cmd()`, but…
Will change to  (ret != ax179_data->eeprom_block) to detect short reads