Re: [PATCH] arm64: dts: qcom: ipq5018: add label to PCIe1 port node

[Kathiravan Thirumoorthy]

On 9/27/2026 10:12 AM, George Moussalem via B4 Relay wrote:
> From: George Moussalem <george.moussalem@xxxxxxxxxxx>
>
> Commit a95758e9718a ("arm64: dts: qcom: ipq5018: move PCIe phys and
> PERST# to port node") added a label to the PCIe0 port node but not to
> that of PCIe1. Boards that have a device connected over PCIe1 need to
> reference the port node in the board dts files, so add a label for it.
>
> Signed-off-by: George Moussalem <george.moussalem@xxxxxxxxxxx>
> ---
>   arch/arm64/boot/dts/qcom/ipq5018.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq5018.dtsi b/arch/arm64/boot/dts/qcom/ipq5018.dtsi
> index fe1ed240de59..2f3bcfa888a9 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5018.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq5018.dtsi
> @@ -838,7 +838,7 @@ pcie1: pcie@80000000 {
>   
>   			status = "disabled";
>   
> -			pcie@0 {
> +			pcie1_port0: pcie@0 {

Although the PCIe1 node currently has a label, unused labels are 
generally discouraged. I couldn't find any upstream references to the 
PCIe1 label. Could you please add the label together with its 
corresponding users?

>   				device_type = "pci";
>   				reg = <0x0 0x0 0x0 0x0 0x0>;
>   				bus-range = <0x01 0xff>;
>
> ---
> base-commit: f5f84daefcd92d7a630066635ecea1433ed5eac7
> change-id: 20260927-ipq5018-pcie1-label-d7d405caf28f
>
> Best regards,