Re: [RFC PATCH 4/8] media: cadence: csi2rx: Add RAW10 RGBIr formats

[Laurent Pinchart]

On Sun, Sep 27, 2026 at 10:50:30AM +0530, Rishikesh Donadkar wrote:
> On 26/09/26 20:22, Laurent Pinchart wrote:
> > On Fri, Sep 25, 2026 at 06:59:57PM +0530, Rishikesh Donadkar wrote:
> >> From: Jai Luthra <j-luthra@xxxxxx>
> >>
> >> Add 10-bit RGBIr formats to the table to allow capturing them.
> >>
> >> Signed-off-by: Jai Luthra <j-luthra@xxxxxx>
> >> Signed-off-by: Rishikesh Donadkar <r-donadkar@xxxxxx>
> >> ---
> >>   drivers/media/platform/cadence/cdns-csi2rx.c | 8 ++++++++
> >>   1 file changed, 8 insertions(+)
> >>
> >> diff --git a/drivers/media/platform/cadence/cdns-csi2rx.c b/drivers/media/platform/cadence/cdns-csi2rx.c
> >> index de7cce76397a..8ed730452d3c 100644
> >> --- a/drivers/media/platform/cadence/cdns-csi2rx.c
> >> +++ b/drivers/media/platform/cadence/cdns-csi2rx.c
> >> @@ -173,6 +173,14 @@ static const struct csi2rx_fmt formats[] = {
> >>   	{ .code	= MEDIA_BUS_FMT_RGB565_1X16,  .bpp = 16, .max_pixels = 1, },
> >>   	{ .code	= MEDIA_BUS_FMT_RGB888_1X24,  .bpp = 24, .max_pixels = 1, },
> >>   	{ .code	= MEDIA_BUS_FMT_BGR888_1X24,  .bpp = 24, .max_pixels = 1, },
> >> +	{ .code	= MEDIA_BUS_FMT_SRGGI10_1X10, .bpp = 10, .max_pixels = 2 },
> >> +	{ .code	= MEDIA_BUS_FMT_SGRIG10_1X10, .bpp = 10, .max_pixels = 2 },
> >> +	{ .code	= MEDIA_BUS_FMT_SBGGI10_1X10, .bpp = 10, .max_pixels = 2 },
> >> +	{ .code	= MEDIA_BUS_FMT_SGBIG10_1X10, .bpp = 10, .max_pixels = 2 },
> >> +	{ .code	= MEDIA_BUS_FMT_SGIRG10_1X10, .bpp = 10, .max_pixels = 2 },
> >> +	{ .code	= MEDIA_BUS_FMT_SIGGR10_1X10, .bpp = 10, .max_pixels = 2 },
> >> +	{ .code	= MEDIA_BUS_FMT_SGIBG10_1X10, .bpp = 10, .max_pixels = 2 },
> >> +	{ .code	= MEDIA_BUS_FMT_SIGGB10_1X10, .bpp = 10, .max_pixels = 2 },
> > 
> > Raw formats will allow supporting all possible CFA patterns without
> > having to extend each driver every time a new pattern is added.
> 
> Yes, makes sense !
> 
> I noticed that patches for RAW format support are present here
> 
> https://git.linuxtv.org/sailus/media_tree.git/log/?h=metadata
> 
> Is there a plan to merge these into media tree in the near future?
> If they are still under review and need more time to get merged, I’ll 
> plan to cherry-pick them and rebase my work on top of them.

Jai is working on the userspace implementation in libcamera to test out
the API. Once that completes, we'll update the API is issues are found,
and then merge it.

> >>   };
> >>   
> >>   static void csi2rx_configure_error_irq_mask(void __iomem *base,

-- 
Regards,

Laurent Pinchart