Re: [PATCH net-next v2 2/9] netlink: specs: rt-link: re-align ifla-inet6-stats

[Hangbin Liu]

On Fri, Sep 25, 2026 at 09:39:05PM +0000, Asbjørn Sloth Tønnesen wrote:
> YNL enum ifla-inet6-stats got misaligned with C, as two commits
> reordered the enum.
> 
> In commit b4a11b2033b7 ("net: fix IPSTATS_MIB_OUTPKGS increment in
> OutForwDatagrams."), IPSTATS_MIB_OUTPKTS was renamed to _OUTREQUESTS
> and a new _OUTPKTS was as the last entry.
> 
> In commit 652e2c777862 ("net: reorganize IP MIB values (II)"), the
> IPSTATS_MIB_* enum was reorganized for data locality.
> 
> Neither of these commits updated the YNL spec.
> 
> This changed uAPI, as IPSTATS_MIB_* is used as indicies in an u64 array,
> exported as IFLA_INET6_STATS by inet6_fill_ifla6_stats_attrs().
> 
> This patch updates ifla-inet6-stats to reflect both of these commits.
> Next time we want to reorganize these counters we should properly apply
> mapping as to maintain the current order on the netlink side.
> 
> While touching these entries, also remove the dash from ect{0,1}-pkts,
> so that they align with the C naming.
> 
> This pre-existing issue was identified by Sashiko during review of
> commit 2b0aecb7b2b1 ("netlink: specs: rt-link: add accept-ra-min-lft").
> 
> Reported-by: Sashiko <sashiko-bot@xxxxxxxxxx>
> Closes: https://sashiko.dev/#/patchset/20260831093458.472180-1-ast%40fiberby.net
> CC: Heng Guo <heng.guo@xxxxxxxxxxxxx>
> Reviewed-by: Jakub Kicinski <kuba@xxxxxxxxxx>
> Signed-off-by: Asbjørn Sloth Tønnesen <ast@xxxxxxxxxxx>
> ---
> Note for Sashiko/Clashiko: Targeting net-next, so no "Fixes" tag.
> 
>  Documentation/netlink/specs/rt-link.yaml | 20 +++++++++++---------
>  1 file changed, 11 insertions(+), 9 deletions(-)
> 
> diff --git a/Documentation/netlink/specs/rt-link.yaml b/Documentation/netlink/specs/rt-link.yaml
> index 8d63933f9910..3560053cea7a 100644
> --- a/Documentation/netlink/specs/rt-link.yaml
> +++ b/Documentation/netlink/specs/rt-link.yaml
> @@ -532,11 +532,21 @@ definitions:
>        -
>          name: indelivers
>        -
> -        name: outforwdatagrams
> +        name: noectpkts
> +      -
> +        name: ect1pkts
> +      -
> +        name: ect0pkts
> +      -
> +        name: cepkts
> +      -
> +        name: outrequests
>        -
>          name: outpkts
>        -
>          name: outoctets
> +      -
> +        name: outforwdatagrams
>        -
>          name: inhdrerrors
>        -
> @@ -587,14 +597,6 @@ definitions:
>          name: outbcastoctets
>        -
>          name: csumerrors
> -      -
> -        name: noectpkts
> -      -
> -        name: ect1-pkts
> -      -
> -        name: ect0-pkts
> -      -
> -        name: cepkts
>        -
>          name: reasm-overlaps
>    - name: br-boolopt-multi
> -- 
> 2.55.0
> 

Reviewed-by: Hangbin Liu <liuhangbin@xxxxxxxxxx>