Re: [PATCH] media: netup_unidvb: set the vb2 queue lock

From: Hohyun Sim

Date: Mon Sep 28 2026 - 01:07:42 EST


Hi Hans, Mauro,

Gentle ping on this patch, sent on 2026-09-10. It is still marked "New"
in the linux-media patchwork with no replies so far:

https://patchwork.linuxtv.org/project/linux-media/patch/20260910063826.112147-1-tlaghgus0425@xxxxxxxxxxx/

Hans, I have added you since this is fallout from your commit
c780d01cf1a6 ("media: vb2: vb2_core_queue_init(): sanity check lock and wait_prepare/finish"):
netup_unidvb sets neither q->lock nor wait_prepare/wait_finish, so since
v6.13 vb2_queue_init() fails in probe and the error path then NULL-derefs
dma->ndev.

One correction to the commit message: the paragraph saying that atomisp,
pwc, msi2500, hackrf, airspy, rcar_drif and video-i2c were fixed for
having "no queue lock and no wait ops" is only right for atomisp, which
got the missing ops in cf738cc7cfe0. The other six already had
wait_prepare/wait_finish and only set the lock after vb2_queue_init(),
so the check did not reject them. That paragraph can simply be dropped
when applying, or I can send a v2 without it if you prefer.

The patch still applies to current mainline.

Thanks,
Hohyun