Re: [PATCH] serial: 8250_mid: Add missing module namespace import for SERIAL_8250
From: Andy Shevchenko
Date: Mon Sep 28 2026 - 04:20:22 EST
On Sun, Sep 27, 2026 at 01:01:17AM +0200, Nathan Chancellor wrote:
> After commit 1c305d5f1daa ("serial: 8250_mid: wait for LSR tx empty
> before setting termios"), modpost errors (or warning with
> CONFIG_MODULE_ALLOW_MISSING_NAMESPACE_IMPORTS=y):
>
> ERROR: modpost: drivers/tty/serial/8250/8250_mid.ko: module uses symbol 'serial8250_wait_for_xmitr' from namespace 'SERIAL_8250', but does not import it.
>
> Add the missing module namespace import to clear up the error/warning.
Oh, indeed, good catch!
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
--
With Best Regards,
Andy Shevchenko