Re: [PATCH 02/11] PCI: tegra194: Check core reset deassertion
From: Andy Shevchenko
Date: Mon Sep 28 2026 - 04:40:54 EST
On Mon, Sep 28, 2026 at 11:15:07AM +0530, Manikanta Maddireddy wrote:
> On 25/09/26 1:55 am, Andy Shevchenko wrote:
> > On Wed, Sep 23, 2026 at 12:52:28PM +0530, Manikanta Maddireddy wrote:
...
> > > + ret = reset_control_deassert(pcie->core_rst);
> > > + if (ret) {
> > > + dev_err(pci->dev, "Failed to deassert core reset: %d\n",
> > > + ret);
> >
> > We have pci_err().
>
> Thank you for taking time to review.
> pci pointer is of type "struct dw_pcie" not "struct pci_dev".
I see, thanks, naming is hard, indeed...
> > > + return ret;
> > > + }
--
With Best Regards,
Andy Shevchenko