Re: [PATCH v2 3/3] soundwire: intel_auxdevice: Don't disable IRQs before removing children

[Charles Keepax]

On Sat, Sep 26, 2026 at 05:55:06PM +0200, Pierre-Louis Bossart wrote:
> 
> > diff --git a/drivers/soundwire/intel_auxdevice.c b/drivers/soundwire/intel_auxdevice.c
> > index 901a71262094f..1439cef43462d 100644
> > --- a/drivers/soundwire/intel_auxdevice.c
> > +++ b/drivers/soundwire/intel_auxdevice.c
> > @@ -508,8 +508,13 @@ static void intel_link_remove(struct auxiliary_device *auxdev)
> >  	if (!bus->prop.hw_disabled) {
> >  		sdw_intel_debugfs_exit(sdw);
> >  		cancel_delayed_work_sync(&cdns->attach_dwork);
> > -		sdw_cdns_enable_interrupt(cdns, false);
> >  	}
> > +
> > +	sdw_bus_slaves_delete(bus);
> > +
> > +	if (!bus->prop.hw_disabled)
> > +		sdw_cdns_enable_interrupt(cdns, false);
> > +
> >  	sdw_bus_master_delete(bus);
> >  }
> 
> sorry, not following - this sequence seems to rely on *two* calls to
> sdw_bus_slaves_delete(), is this intentional or I am missing something?
> 
> 
>  void sdw_bus_master_delete(struct sdw_bus *bus)
>  {
> -	device_for_each_child(bus->dev, NULL, sdw_delete_slave);
> +	sdw_bus_slaves_delete(bus); <<< this would be the second call?
> +	sdw_bus_slaves_put(bus);

Yeah seemed the simplest way to not have to change any existing
drivers, the second call is a complete no-op if the first was
done.

Thanks,
Charles