Re: [PATCH] rust: proc-macro2: enable `proc_macro_span` feature

[Miguel Ojeda]

On Mon, Sep 21, 2026 at 1:57 PM Gary Guo <gary@xxxxxxxxxx> wrote:
>
> Miguel, please let me know if you're okay with the proc-macro2
> modification.
>
> I'd like to take this via pin-init-next if possible.

If you think the diagnostics improvements are worth it, then I guess
it is fine. The ones in the commit message do not seem like a big
deal, but I assume the upcoming ones you mention in pin-init are
bigger improvements?

(I would also probably had shown the improved example outputs in the
commit message for comparison; and especially one of the upcoming ones
if those are more important to get right)

If so, then please feel free to pick it up, thanks! The change itself
looks good.

Link: https://github.com/rust-lang/rust/issues/54725

I would also wrap the `README.md` like

  identifiers, to remove the `unicode-ident` dependency, and to build
  with 1.85 with nightly features enabled.

to keep it like the previous lines.

Nit: "a overall" -> "an overall"

Cheers,
Miguel