Re: [PATCH 1/2] dt-bindings: arm: qcom,ids: Add SoC ID for SM8950

From: Krzysztof Kozlowski

Date: Mon Sep 28 2026 - 06:12:16 EST


On Thu, Sep 24, 2026 at 09:28:20AM +0200, Konrad Dybcio wrote:
> On 9/23/26 9:06 AM, Krzysztof Kozlowski wrote:
> > On 23/09/2026 01:06, Jingyi Wang wrote:
> >> Add the ID for the Qualcomm SM8950 SoC which represents the Maili
> >> platform.
> >>
> >> Signed-off-by: Jingyi Wang <jingyi.wang@xxxxxxxxxxxxxxxx>
> >> ---
> >> include/dt-bindings/arm/qcom,ids.h | 1 +
> >
> >
> > Standard question: where is DTS? Why is this sent separately from the
> > rest of the patches targeting the same subsystem? Please organize entire
> > work targeting maintainers in relevant patchsets.
>
> I see no reason for the grumpiness here, this is perfectly okay in
> my books
>
> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>

Still, having it separate from initial DTS for the SoC brings no
benefits. I am not grumpy, having this groupped makes things easier to
review.

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>

Best regards,
Krzysztof