Re: [PATCH] pinctrl: qcom: ipq5018: add required gpios and missing PWM functions

[Konrad Dybcio]

On 9/24/26 2:22 PM, George Moussalem via B4 Relay wrote:
> From: George Moussalem <george.moussalem@xxxxxxxxxxx>
> 
> On multiple Linksys routers, GPIO 1, 30, and 46 are used to drive the
> PWM led on PWM1, PWM3, and PWM0 channels respectively, so let's update
> the pwm# and pingroups accordingly.
> 
> Signed-off-by: George Moussalem <george.moussalem@xxxxxxxxxxx>
> ---
>  drivers/pinctrl/qcom/pinctrl-ipq5018.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/pinctrl/qcom/pinctrl-ipq5018.c b/drivers/pinctrl/qcom/pinctrl-ipq5018.c
> index 84392fe258c9..74fccdd5146a 100644
> --- a/drivers/pinctrl/qcom/pinctrl-ipq5018.c
> +++ b/drivers/pinctrl/qcom/pinctrl-ipq5018.c
> @@ -539,7 +539,7 @@ static const char * const qdss_tracectl_b_groups[] = {
>  };
>  
>  static const char * const pwm0_groups[] = {
> -	"gpio42",
> +	"gpio42", "gpio46",
>  };
>  
>  static const char * const qdss_cti_trig_out_b0_groups[] = {
> @@ -547,7 +547,7 @@ static const char * const qdss_cti_trig_out_b0_groups[] = {
>  };
>  
>  static const char * const pwm1_groups[] = {
> -	"gpio43",
> +	"gpio43", "gpio1",

Nit: please keep the added entries sorted

Konrad