Re: [PATCH 1/3] dt-bindings: phy: qcom,sa8775p-dwmac-sgmii-phy: add Nord compatible

[Mohd Ayaan Anwar]

On Mon, Sep 28, 2026 at 12:16:45PM +0200, Krzysztof Kozlowski wrote:
> On Wed, Sep 23, 2026 at 05:34:17AM +0530, Mohd Ayaan Anwar wrote:
> > Add the qcom,nord-dwmac-sgmii-phy compatible to the Qualcomm DWMAC
> > SGMII PHY binding.
> 
> Why random order? Why not enum with existing part?

You are right. I will group the stanalone compatibles into a single enum
and sort them alphabetically in v2.

> Why not even compatible with existing device?

Nord uses the QMP v7 SerDes register layout, whereas sa8775p uses the
v5 layout. The offsets differ, so Nord cannot use
qcom,sa8775p-dwmac-sgmii-phy as a fallback compatible.

> 
> So many questions, yet commit msg copies subject.
> 

Sorry about that. I mentioned the QMP v7 details in the cover letter
but forgot to include them in the commit message. I will expand the
commit message in v2 to describe the hardware differences and
explain why there is no fallback compatible.

Thank you for the review.

	Ayaan