Re: [PATCH net-next 2/2] dpaa2-eth: DPNIs without a DPMAC should be virtual devlink ports

[Vincent Jardin]

Hi Ioana,

> > A DPNI whose endpoint is not a DPMAC has no physical connector: it
> > may have no endpoint at all, or be connected to another DPNI or to a
> > DPSW port. It is still registered as a physical devlink port, number 0,
> > so userspace sees a physical port that does not exist.
> 
> Reword this so that it's clear that you are describing the state before
> the patch.

Done, see v2

> > A virtual port has no phys_port_name, so only the DPNIs that serve a
> > DPMAC report one, and "p<dpmac id>" never collides.
> 
> Reword this as well and mention directly what you are changing.

Done,

> 
> I would also suggest a change in the subject title:
>  dpaa2-eth: mark DPNIs without a DPMAC as virtual devlink ports

OK, thanks for the suggestion

> >  void dpaa2_eth_dl_port_check(struct dpaa2_eth_priv *priv)
> >  {
> > -	u32 registered = priv->devlink_port.attrs.phys.port_number;
> > +	const struct devlink_port_attrs *attrs = &priv->devlink_port.attrs;
> >  	u32 current_number = dpaa2_eth_dl_port_number(priv);
> > +	u32 registered = 0;
> 
> Move these changes to patch 1/2.


ok, done

Thanks for the comments,
  Vincent