Re: [PATCH v2 8/9] gpu: nova-core: gsp: move the RPC commands into a sub-module
From: Alexandre Courbot
Date: Mon Sep 28 2026 - 07:46:48 EST
On Mon Sep 28, 2026 at 6:20 PM JST, Zhi Wang wrote:
> On Sun, 27 Sep 2026 22:46:25 +0900
> Alexandre Courbot <acourbot@xxxxxxxxxx> wrote:
>
>> Move the types and code related to RPC commands into the
>> `rpc` sub-module, and update their users to reference them from their
>> new location.
>>
>> This is a pure move commit, with no functional change intended.
>>
>
> Hi Alex:
>
> What would be the plan for commands.rs in the future after the movement?
> I was adopting the similar code structures (fw.rs/command.rs) for vGPU
> manager's RPCs and GSP plugin RPCs, e.g. having RPC typed code and
> function handler(wrapper)s, it would be nice that I can align with the
> idea accordingly.
Can you point me to the the structure you have if it is posted? (sorry,
too many series in-flight and I cannot find where it is ^_^;)
If you add vGPU RPC commands then I guess somewhere like
`gsp/commands/rpc/vgpu.rs` would be a good place for them. But let's
wait until this series is approved before settling on a design - moving
code around is easy anyway.