Re: [PATCH 1/3] rust: pin-init: internal: handle item and expr diagnostics differently

From: Gary Guo

Date: Mon Sep 28 2026 - 08:00:35 EST


Applied to pin-init-next, with R-b tag provided by Benno in person.

95593ed36161 rust: pin-init: internal: improve diagnostics robustness against panicking
rust/pin-init/internal/src/diagnostics.rs | 24 ++++++++++++++++++++++--
1 file changed, 22 insertions(+), 2 deletions(-)

73c1f157907c rust: pin-init: internal: make `DiagCtxt` available inside parser
rust/pin-init/internal/src/diagnostics.rs | 84 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------------
rust/pin-init/internal/src/init.rs | 41 ++++++++++++++---------------------------
rust/pin-init/internal/src/lib.rs | 32 +++++++++++++++++---------------
3 files changed, 96 insertions(+), 61 deletions(-)
[ Reflow the long diagnostics message that exceeds 100 columns. ]

01c3d218e8fa rust: pin-init: internal: handle item and expr diagnostics differently
rust/pin-init/internal/src/diagnostics.rs | 55 +++++++++++++++++++++++++++++++++++++++++++++++--------
rust/pin-init/internal/src/lib.rs | 12 ++++++------
2 files changed, 53 insertions(+), 14 deletions(-)

Best,
Gary